* Pedanekar, Hemant <hemantp@xxxxxx> [101210 16:58]: > Tony Lindgren wrote on Monday, December 06, 2010 10:23 PM: > > [...] > >> Similarly, we will also need to add TI816X specific hwmods. > >> > >> 4) TI816X series shares similarity with OMAP4 too - e.g., various IPs are > >> same, CM module is closer to OMAP4 than OMAP3. Thus, regaring (1) above, I > >> could use OMAP4 code instead of adding new "else if". Of course, again, > >> there are above mentioned differences too. > > > > We really want to use same code for the shared modules so > > using feature > > based detection is the way to go. > > > Tony, > > Just wanted to confirm: so you are suggesting we do not have any > cpu_is_ti81xx() check in the code - is that correct? We can have that, but we should avoid it where possible. And ideally cpu_is_ti81xx() would be just something like: #define cpu_is_ti81xx() \\ cpu_is_omap34xx() && omap_has_aaa() && omap_has_bbb() Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
