On Fri, Nov 19, 2010 at 1:12 PM, Nishanth Menon <nm@xxxxxx> wrote: > Jean Pihet wrote, on 11/19/2010 04:09 AM: > [...] >>> >>> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c >>> index f520b38..c7e2db0 100644 >>> --- a/arch/arm/mach-omap2/pm34xx.c >>> +++ b/arch/arm/mach-omap2/pm34xx.c >>> @@ -422,6 +422,14 @@ void omap_sram_idle(void) >>> omap3_per_save_context(); >>> } >>> >>> + /* >>> + * We need to disable the autoidle bit from MPU INTC, >>> + * otherwise INTC would get stall, and we would never >>> + * come out of WFI. This is done here because >>> + * save secure ram also does WFI. >>> + */ >> >> The comment should mention the errata ID i540, for easier readability >> and maintenance. > > Thanks for your review. I agree + I was given an offline feedback: > > 1 bug = Erratum > 1+ bug = Errata Argh I did the same mistake. My latin lessons must be too for away now ;-) > > ;) I should be fixing my grammar throughout all patches - so I believe they > all become Erratum ID: etc.. will try to fix them as well in my v2. > Thanks, Jean > > -- > Regards, > Nishanth Menon > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
