Yes Balbi. I will incorporate your comments.
Regards
Gowda
________________________________________
From: linux-omap-owner@xxxxxxxxxxxxxxx [linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of ext Felipe Balbi [balbi@xxxxxx]
Sent: Friday, November 19, 2010 1:47 PM
To: Gowda Madhusudhan.1 (EXT-Elektrobit/Helsinki)
Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx
Subject: Re: [PATCH] OMAP3: PM: PRCM interrupt: Fix warning "MPU wakeup but no wakeup sources"
Hi,
On Fri, Nov 19, 2010 at 01:26:33PM +0200, Madhusudhan Gowda wrote:
>@@ -277,13 +278,16 @@ static irqreturn_t prcm_interrupt_handler (int irq, void *dev_id)
> if (irqstatus_mpu & (OMAP3430_WKUP_ST_MASK |
> OMAP3430_IO_ST_MASK)) {
> c = _prcm_int_handle_wakeup();
>+ ct++;
>
> /*
> * Is the MPU PRCM interrupt handler racing with the
> * IVA2 PRCM interrupt handler ?
> */
>- WARN(c == 0, "prcm: WARNING: PRCM indicated MPU wakeup "
>- "but no wakeup sources are marked\n");
>+ if (ct == 1)
>+ WARN(c == 0, "prcm: WARNING: PRCM indicated "
>+ "MPU wakeup but no wakeup sources "
>+ "are marked\n");
WARN(!c && (ct == 1), "prcm: WARNING: PRCM indicated "
"MPU wakeup but no wakeup sources "
"are marked\n");
would do it? Then you don't need the extra if ().
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
