"Varadarajan, Charulatha" <charu@xxxxxx> writes: > Tony, Benoit, Kevin, > >> > >> > > >> > >> > > I think that disabling it should be done only if the >> > CONFIG_OMAP_WDT >> > >> > > is not set. >> > >> > >> > >> > How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT >> > >> > is set? >> > >> >> > >> As given in the patch description, this patch does a disable of >> > watchdog >> > >> timer, during init, to avoid the system rebooting that happens due to >> > >> enabling of watchdog timer after a reset of the module (during hwmod >> > init). >> > >> >> > >> According to the default WDT registers values, the system reboot >> would >> > >> happen in ~10s if watchdog is enabled with default values. Hence, >> after >> > >> a WDT module reset during init, the watchdog has to be disabled >> within >> > 10s >> > >> otherwise the system will keep rebooting. >> > >> >> > >> Hence irrespective of CONFIG_WATCHDOG_NOWAYOUT/ CONFIG_OMAP_WDT, >> > >> the watchdog timer needs to be disabled after a WDT reset has >> happened. >> > >> >> > > One more option is to avoid the software reset using the >> CONFIG_OMAP_WDT >> > > flag. Something like below. >> > >> > This was already proposed by Charu, and rejected. >> > >> > Doing this means we have a dependency on particular bootloader init, and >> > we'd like to get rid of *all* assumptions about what the bootloader does >> > (or does not do.) >> > >> you mean is not depeding on bootloader to disable WDT. Make sense. >> > > Let me know your opinion on how to handle this issue. IMO, we should do what your original patch did: always disable the WDT, just like most/all bootloaders do. If we want to make changes later to support product needs (like no disable on boot, etc.) that is a separate issue and should be done in a separate patch. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
