> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, September 30, 2010 10:42 PM > To: Shilimkar, Santosh > Cc: Varadarajan, Charulatha; Tony Lindgren; Cousson, Benoit; Menon, > Nishanth; wim@xxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; linux- > watchdog@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > paul@xxxxxxxxx; Nayak, Rajendra; Basak, Partha > Subject: Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during > init > > "Shilimkar, Santosh" <santosh.shilimkar@xxxxxx> writes: > > >> -----Original Message----- > >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > >> owner@xxxxxxxxxxxxxxx] On Behalf Of Varadarajan, Charulatha > >> Sent: Thursday, September 30, 2010 9:25 PM > >> To: Tony Lindgren; Cousson, Benoit > >> Cc: Kevin Hilman; Menon, Nishanth; wim@xxxxxxxxx; linux- > >> omap@xxxxxxxxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx; linux-arm- > >> kernel@xxxxxxxxxxxxxxxxxxx; paul@xxxxxxxxx; Nayak, Rajendra; Basak, > Partha > >> Subject: RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset > during > >> init > >> > >> Tony/ Benoit, > >> > >> > > > >> > > I think that disabling it should be done only if the > CONFIG_OMAP_WDT > >> > > is not set. > >> > > >> > How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT > >> > is set? > >> > >> As given in the patch description, this patch does a disable of > watchdog > >> timer, during init, to avoid the system rebooting that happens due to > >> enabling of watchdog timer after a reset of the module (during hwmod > init). > >> > >> According to the default WDT registers values, the system reboot would > >> happen in ~10s if watchdog is enabled with default values. Hence, after > >> a WDT module reset during init, the watchdog has to be disabled within > 10s > >> otherwise the system will keep rebooting. > >> > >> Hence irrespective of CONFIG_WATCHDOG_NOWAYOUT/ CONFIG_OMAP_WDT, > >> the watchdog timer needs to be disabled after a WDT reset has happened. > >> > > One more option is to avoid the software reset using the CONFIG_OMAP_WDT > > flag. Something like below. > > This was already proposed by Charu, and rejected. > > Doing this means we have a dependency on particular bootloader init, and > we'd like to get rid of *all* assumptions about what the bootloader does > (or does not do.) > you mean is not depeding on bootloader to disable WDT. Make sense. Thanks Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
