Re: [PATCH] [OMAP] HTCHERALD: MMC, I2C, HTCPLD, SPI, TSC2046

[Cory Maccarrone <darkstar6262@xxxxxxxxx>]

On Thu, Sep 30, 2010 at 11:48 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Cory Maccarrone <darkstar6262@xxxxxxxxx> [100930 11:34]:
>> >
>> > Looks like also board-sx1-mmc.c and board-h[23]-mmc.c have the
>> > same spotty voltage range.
>> >
>> > Cory, care to do a patch that fixes it for all of them?
>> >
>>
>> Yeah, I can do that. ÂI'll resubmit this patch too with the fixed up ranges.
>
> Turns out I already did it :) Care to test/ack this one?
>
> Tony
>
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Date: Thu, 30 Sep 2010 11:40:56 -0700
> Subject: [PATCH] omap: Fix spotty MMC voltages
>
> As noted by MichaÅ MirosÅaw <mirqus@xxxxxxxxx>, the voltages should
> cover the supported voltage range instead of missing some values
> within the range.
>
> Reported-by: MichaÅ MirosÅaw <mirqus@xxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
>
> diff --git a/arch/arm/mach-omap1/board-h2-mmc.c b/arch/arm/mach-omap1/board-h2-mmc.c
> index b30c499..50d9032 100644
> --- a/arch/arm/mach-omap1/board-h2-mmc.c
> +++ b/arch/arm/mach-omap1/board-h2-mmc.c
> @@ -58,7 +58,8 @@ static struct omap_mmc_platform_data mmc1_data = {
>    Â.dma_mask            = 0xffffffff,
> Â Â Â Â.slots[0] Â Â Â = {
>        Â.set_power       Â= mmc_set_power,
> -        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_30_31 |
> +        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_29_30 |
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_30_31 | MMC_VDD_31_32 |
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂMMC_VDD_32_33 | MMC_VDD_33_34,
>        Â.name          = "mmcblk",
> Â Â Â Â},
> diff --git a/arch/arm/mach-omap1/board-h3-mmc.c b/arch/arm/mach-omap1/board-h3-mmc.c
> index 54b0f06..9f073bf 100644
> --- a/arch/arm/mach-omap1/board-h3-mmc.c
> +++ b/arch/arm/mach-omap1/board-h3-mmc.c
> @@ -40,7 +40,8 @@ static struct omap_mmc_platform_data mmc1_data = {
>    Â.dma_mask            = 0xffffffff,
> Â Â Â Â.slots[0] Â Â Â = {
>        Â.set_power       Â= mmc_set_power,
> -        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_30_31 |
> +        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_29_30 |
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_30_31 | MMC_VDD_31_32 |
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂMMC_VDD_32_33 | MMC_VDD_33_34,
>        Â.name          = "mmcblk",
> Â Â Â Â},
> diff --git a/arch/arm/mach-omap1/board-htcherald.c b/arch/arm/mach-omap1/board-htcherald.c
> index 7ea75c1..909fdeb 100644
> --- a/arch/arm/mach-omap1/board-htcherald.c
> +++ b/arch/arm/mach-omap1/board-htcherald.c
> @@ -410,7 +410,8 @@ static struct omap_mmc_platform_data htc_mmc1_data = {
>    Â.nr_slots            = 1,
>    Â.switch_slot          Â= NULL,
> Â Â Â Â.slots[0] Â Â Â = {
> -        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_30_31 |
> +        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_29_30 |
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_30_31 | MMC_VDD_31_32 |
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂMMC_VDD_32_33 | MMC_VDD_33_34,
>        Â.name          = "mmcblk",
>        Â.nomux         Â= 1,
> diff --git a/arch/arm/mach-omap1/board-sx1-mmc.c b/arch/arm/mach-omap1/board-sx1-mmc.c
> index 5b33ae8..be5a365 100644
> --- a/arch/arm/mach-omap1/board-sx1-mmc.c
> +++ b/arch/arm/mach-omap1/board-sx1-mmc.c
> @@ -44,7 +44,8 @@ static struct omap_mmc_platform_data mmc1_data = {
>    Â.nr_slots            = 1,
> Â Â Â Â.slots[0] Â Â Â = {
>        Â.set_power       Â= mmc_set_power,
> -        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_30_31 |
> +        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_29_30 |
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_30_31 | MMC_VDD_31_32 |
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂMMC_VDD_32_33 | MMC_VDD_33_34,
>        Â.name          = "mmcblk",
> Â Â Â Â},
> diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
> index 7a93bd5..abd7e77 100644
> --- a/arch/arm/mach-omap2/board-n8x0.c
> +++ b/arch/arm/mach-omap2/board-n8x0.c
> @@ -493,7 +493,8 @@ static struct omap_mmc_platform_data mmc1_data = {
>        Â.set_bus_mode      = n8x0_mmc_set_bus_mode,
>        Â.get_cover_state    Â= n8x0_mmc_get_cover_state,
>        Â.ocr_mask        = MMC_VDD_165_195 | MMC_VDD_30_31 |
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_32_33 Â | MMC_VDD_33_34,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_31_32 | MMC_VDD_32_33 |
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_33_34,
>        Â.name          = "internal",
> Â Â Â Â},
> Â Â Â Â.slots[1] = {
>

Sure thing, hopefully in the next day or two. :)

- Cory
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þ‰š§ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf