Hi, >-----Original Message----- >From: Balbi, Felipe >Sent: Friday, September 24, 2010 4:35 PM >To: Kalliguddi, Hema >Cc: Balbi, Felipe; Kevin Hilman; linux-omap@xxxxxxxxxxxxxxx; >linux-usb@xxxxxxxxxxxxxxx; Basak, Partha; Tony Lindgren; >Cousson, Benoit; Paul Walmsley >Subject: Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. > >Hi, > >On Fri, Sep 24, 2010 at 06:00:26AM -0500, Kalliguddi, Hema wrote: >>then for now I can think of using set_clok platform function to call >>the runtime pm apis, Is there any alternative you are thinking of? > >how about not pushing a patch which isn't the best way to solve the >problem in the first place ? .38 isn't that far away. If we can get all >those cleanups by that time, converting to pm_runtime will be a lot >simpler and local change. > >I mean, if we keep as is for another major release cycle, it >won't cause >problems to anyone, right ? So it's better to get things right from the >beginning and avoid lots of re-work later. > Agreed that it is better to get the things done in the best way from the beginning. This may not be the best solution for converting usb to use runtime pm apis, but given the current mainline code, without the cleanup, do not have other alternatives. Do you think the other patches are in good shape to merge after fixing the comments I got from Kevin and Benoit and you? Kevin, Do you have any other comments on the hwmod patches other than runtime pm patch and offmode patch? Do you accept the hwmod patches without the runtime pm conversion? >-- >balbi >-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html