Felipe, >-----Original Message----- >From: Balbi, Felipe >Sent: Friday, September 24, 2010 2:14 PM >To: Kalliguddi, Hema >Cc: Kevin Hilman; Balbi, Felipe; linux-omap@xxxxxxxxxxxxxxx; >linux-usb@xxxxxxxxxxxxxxx; Basak, Partha; Tony Lindgren; >Cousson, Benoit; Paul Walmsley >Subject: Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. > >Hi, > >On Fri, Sep 24, 2010 at 03:16:29AM -0500, Kalliguddi, Hema wrote: >>>I guess that's Felipe's call, but I don't like that option. >>> >>>I think it's cleaner to have the ->set_clock hook be a noop on OMAP >>>and the runtime hooks be noops on the other platforms. >>> >>I think the set_clock function was used for setting the platform >>specific clocks for different architecture. Anyway we need >this hook or >>some other hook once we start handling the optional clocks >and internal >>phy clocks for musb. Since this is already exists I thought of making >>use of it instand of adding another hook. >> >>Felipe, What do you say? > >Ideally we will get rid of those. It's only a matter of getting DaVinci >to fully support clkdev. We should not have wrappers on top of clk >framework neither pass down clock names as platform_data to driver, >that's insane. > I think we will need to have some hooks for handling the clocks for different platform as each platforms will have different clocks. The way we are using set_clock is not the wrapper on top clock frameowrk, it is a platform hook to enabling the clocks which still uses the clock framework. ~Hema >-- >balbi >-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
