Kevin Hilman wrote:
> "Ramirez Luna, Omar" <omar.ramirez@xxxxxx> writes:
>
>> Ramirez Luna, Omar wrote:
>>> Fix the mailbox support detection for OMAP3630, 3530/25 and 2430.
>>>
>>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxx>
>>> ---
>>> - Testing was made under 3630 and 3430 boards.
>>> - Given that 2430 uses similar initialization than OMAP3, changes
>>> to handle this case was added to the patch.
>>> - HWMOD adaptation hopefully should solve this mess, but as of now
>>> mailbox should work as before at least.
>>>
>>> arch/arm/mach-omap2/mailbox.c | 12 ++++++++----
>>> 1 files changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/mailbox.c
>>> b/arch/arm/mach-omap2/mailbox.c index 42dbfa4..26d6fb0 100644 ---
>>> a/arch/arm/mach-omap2/mailbox.c +++ b/arch/arm/mach-omap2/mailbox.c
>>> @@ -394,15 +394,19 @@ static int __devinit omap2_mbox_probe(struct
>>> platform_device *pdev)
>>>
>>> if (false)
>>> ;
>>> -#if defined(CONFIG_ARCH_OMAP3430)
>>> - else if (cpu_is_omap3430()) {
>>> +#if defined(CONFIG_ARCH_OMAP3)
>>> + else if (omap3_has_iva()) {
>>
>> Hmm, seems omap3_has_ ##feat are only available for built-in and not
>> module configurations, this patch is not so good after all since it
>> throws:
>>
>> ERROR: "omap3_features" [arch/arm/mach-omap2/mailbox_mach.ko]
>> undefined!
>
> Well, feature detection certainly should be available to modules.
>
> How about proposing a simple fix for this. Something like the
> following (untested) should work, since the individual omap3_has_*
> checks are static inlines.
Ok great, I wasn't sure if exporting this variable as a symbol was desired. Will try and resend.
Regards,
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
