* Govindraj <govindraj.ti@xxxxxxxxx> [100607 17:50]: > On Mon, Jun 7, 2010 at 5:02 PM, Govindraj <govindraj.ti@xxxxxxxxx> wrote: > > On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > >> * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100604 18:30]: > >>> > >>> > + w &= ~0x7; > >>> > + w |= OMAP_MUX_MODE2; > >>> > + omap_ctrl_writew(w, uart->padconf); > >> > >> Generic NAK for tinkering with the mux registers directly. > >> > >> Instead, Govindraj, please add omap_mux_request_signal() into mux.c: > >> > >> void __iomem * __init omap_mux_request_signal(char *muxname); > > Looking into mach-omap2/mux.c > > Wouldn't retrieving offset will be enough as i have to depend on > again *_mux_* function call for remux which can have the offset and val > as parameter. You call omap_mux_request_signal with the signal name, and get the register address. Then you can just set it with readw/writew. > So I need to use ""K15_24XX_UART3_TX" as name to retrieve > UART3 offset if I am correct and traverse through the list doing an strcmp > on name to retrieve offset. > > In that case I dont find uart1/2/4 in list, > Should that be added into the list? No, that's the old mux code. You want to do something like void __iomem *uart1_rx; uart1_rx = omap_mux_request_signal("uart1_rx"); if (!uart1_rx) return -ENODEV; ... See the signal names in mux34xx.c and the TRM. Then omap2 and omap4 will work automatically once the mux code is ready for those. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html