Re: [pm-wip/uart][PATCH 2/4] OMAP3: serial: Fix uart4 handling for 3630

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 7, 2010 at 5:02 PM, Govindraj <govindraj.ti@xxxxxxxxx> wrote:
> On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>> * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100604 18:30]:
>>>
>>> > +   w &= ~0x7;
>>> > +   w |= OMAP_MUX_MODE2;
>>> > +   omap_ctrl_writew(w, uart->padconf);
>>
>> Generic NAK for tinkering with the mux registers directly.
>>
>> Instead, Govindraj, please add omap_mux_request_signal() into mux.c:
>>
>> void __iomem * __init omap_mux_request_signal(char *muxname);

Looking into mach-omap2/mux.c

Wouldn't retrieving offset will be enough as i have to depend on
again *_mux_* function call for remux which can have the offset and val
as parameter.

So I need to use  ""K15_24XX_UART3_TX" as name to retrieve
UART3 offset if I am correct and traverse through the list doing an strcmp
on name to retrieve offset.

In that case I dont find uart1/2/4 in list,
Should that be added into the list?

Regards,
Govindraj.R

>>
>> Which returns the address of the mux register in question based
>> on the signal name. Then in the platform init code you can request
>> the pins for all the UARTs in use, and provide functions to remux
>> them as needed for the idle modes.
>>
>> This will work for omap2 also at some point once it's converted to
>> use the common mux framework. And it will work in a generic way
>> for all omaps under mach-omap2 eventually.
>>
>> You can take a look at the omap_mux_get_gpio() in mux.c for a
>> similar example.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux