On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100604 18:30]: >> >> > + w &= ~0x7; >> > + w |= OMAP_MUX_MODE2; >> > + omap_ctrl_writew(w, uart->padconf); > > Generic NAK for tinkering with the mux registers directly. > > Instead, Govindraj, please add omap_mux_request_signal() into mux.c: > > void __iomem * __init omap_mux_request_signal(char *muxname); > > Which returns the address of the mux register in question based > on the signal name. Then in the platform init code you can request > the pins for all the UARTs in use, and provide functions to remux > them as needed for the idle modes. > > This will work for omap2 also at some point once it's converted to > use the common mux framework. And it will work in a generic way > for all omaps under mach-omap2 eventually. > > You can take a look at the omap_mux_get_gpio() in mux.c for a > similar example. ok fine, will check out. Thanks for the review. --- Regards, Govindraj.R > > Regards, > > Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
