Hi Hari, From: ext Hari Kanigeri <h-kanigeri2@xxxxxx> Subject: [PATCH 1/2] omap: iommu-update irq mask to be specific about twl Date: Tue, 18 May 2010 01:12:29 +0200 > Update the irq mask so that is is clear that the MMU ~~typo? > interrupt is related to TWL fault. > > Signed-off-by: Hari Kanigeri <h-kanigeri2@xxxxxx> > --- > arch/arm/mach-omap2/iommu2.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c > index e82da68..fcf4f4a 100644 > --- a/arch/arm/mach-omap2/iommu2.c > +++ b/arch/arm/mach-omap2/iommu2.c > @@ -46,7 +46,13 @@ > #define MMU_IRQ_TLBMISS (1 << 0) > #define MMU_IRQ_MASK \ > (MMU_IRQ_MULTIHITFAULT | MMU_IRQ_TABLEWALKFAULT | MMU_IRQ_EMUMISS | \ > - MMU_IRQ_TRANSLATIONFAULT) > + MMU_IRQ_TRANSLATIONFAULT | MMU_IRQ_TLBMISS) > +#define MMU_IRQ_TWL_MASK \ > + (MMU_IRQ_MULTIHITFAULT | MMU_IRQ_TABLEWALKFAULT | MMU_IRQ_EMUMISS | \ > + MMU_IRQ_TRANSLATIONFAULT) > +#define MMU_IRQ_TLB_MISS_MASK \ > + (MMU_IRQ_MULTIHITFAULT | MMU_IRQ_TLBMISS | MMU_IRQ_EMUMISS | \ > + MMU_IRQ_TRANSLATIONFAULT) nitpick: The above could look better as blew? #define __MMU_IRQ_FAULT (MMU_IRQ_MULTIHITFAULT | MMU_IRQ_EMUMISS | MMU_IRQ_TRANSLATIONFAULT) #define MMU_IRQ_MASK (__MMU_IRQ_FAULT | MMU_IRQ_TABLEWALKFAULT | MMU_IRQ_TLBMISS) #define MMU_IRQ_TWL_MASK (__MMU_IRQ_FAULT | MMU_IRQ_TABLEWALKFAULT) #define MMU_IRQ_TLB_MISS_MASK (__MMU_IRQ_FAULT | MMU_IRQ_TLBMISS) > > /* MMU_CNTL */ > #define MMU_CNTL_SHIFT 1 > @@ -96,7 +102,7 @@ static int omap2_iommu_enable(struct iommu *obj) > l |= (MMU_SYS_IDLE_SMART | MMU_SYS_AUTOIDLE); > iommu_write_reg(obj, l, MMU_SYSCONFIG); > > - iommu_write_reg(obj, MMU_IRQ_MASK, MMU_IRQENABLE); > + iommu_write_reg(obj, MMU_IRQ_TWL_MASK, MMU_IRQENABLE); > iommu_write_reg(obj, pa, MMU_TTB); > > l = iommu_read_reg(obj, MMU_CNTL); > -- > 1.7.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html