From: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> Subject: Re: [PATCH 1/4] omap: mailbox: convert rwlocks to spinlock Date: Mon, 10 May 2010 13:40:14 +0300 (EEST) > Hi Felipe, > > From: ext Felipe Contreras <felipe.contreras@xxxxxxxxx> > Subject: Re: [PATCH 1/4] omap: mailbox: convert rwlocks to spinlock > Date: Mon, 10 May 2010 12:12:52 +0200 > >> On Mon, May 10, 2010 at 12:16 PM, Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> wrote: >>> From: Ohad Ben-Cohen <ohad@xxxxxxxxxx> >>> >>> rwlocks are slower and have potential starvation issues >>> therefore spinlocks are generally preferred. >>> >>> see also: http://lwn.net/Articles/364583/ >>> >>> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx> >>> Signed-off-by: Kanigeri Hari <h-kanigeri2@xxxxxx> >>> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> >> >> There's no cover letter, so I'll comment here. >> >> What about these patches? >> http://article.gmane.org/gmane.linux.ports.arm.omap/31208 > > OK, I'll incorporate them and send patches again. The above has been sent to LAKML by Tony a while ago. I just rebased Ohad's ones on the top of Fernando's. The following changes since commit b57f95a38233a2e73b679bea4a5453a1cc2a1cc9: Linux 2.6.34-rc7 (2010-05-09 18:36:28 -0700) are available in the git repository at: git://gitorious.org/~doyu/lk/mainline.git v2.6.34-rc7.mailbox Fernando Guzman Lugo (4): Mailbox: free mailbox interrupt before freeing blk queue Mailbox: flush pending deferred works before freeing blk queue Mailbox: Check valid registered callback before calling Mailbox: disable mailbox interrupt when request queue Hiroshi DOYU (1): Mailbox: new mutext lock for h/w mailbox configuration Ohad Ben-Cohen (4): omap: mailbox: convert rwlocks to spinlock omap: mailbox cleanup: split MODULE_AUTHOR line omap: mailbox: remove (un)likely macros from cold paths omap: mailbox: convert block api to kfifo arch/arm/mach-omap2/mailbox.c | 3 +- arch/arm/plat-omap/Kconfig | 9 ++ arch/arm/plat-omap/include/plat/mailbox.h | 4 +- arch/arm/plat-omap/mailbox.c | 169 ++++++++++++++--------------- 4 files changed, 97 insertions(+), 88 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
