Nishanth Menon <nm@xxxxxx> writes: > Manjunatha GK had written, on 04/26/2010 08:18 AM, the following: >> The zoom3 defconfig build is broken with opp patches. >> This patch will fix the same. Build and boot tested on >> omap zoom3 board. >> >> Build error log: >> In file included from arch/arm/plat-omap/include/plat/omap-pm.h:21, >> from arch/arm/mach-omap2/hsmmc.c:19: >> arch/arm/plat-omap/include/plat/opp.h: In function 'opp_find_freq_exact': >> arch/arm/plat-omap/include/plat/opp.h:255: error: implicit declaration of function 'ERR_PTR' > > I think this is a valid change, though I think commit message is not > informative enough in this case. the problem is that opp.h defines a > set of empty access functions for use when CPUFREQ is not defined, > which is the case you seem to be hitting. it is not restricted to > zoom3 defconfig. > > If you could rephrase the commit message accordingly, it would be helpful. No need... I found a few other problems related to CPUfreq not being enabled and I folded the fixes into the original commits and rebase pm-opp. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html