Re: [PATCH] OMAP3: PM: Fix zoom3 defconfig build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Manjunatha GK had written, on 04/26/2010 08:18 AM, the following:
The zoom3 defconfig build is broken with opp patches.
This patch will fix the same. Build and boot tested on
omap zoom3 board.

Build error log:
In file included from arch/arm/plat-omap/include/plat/omap-pm.h:21,
                 from arch/arm/mach-omap2/hsmmc.c:19:
arch/arm/plat-omap/include/plat/opp.h: In function 'opp_find_freq_exact':
arch/arm/plat-omap/include/plat/opp.h:255: error: implicit declaration of function 'ERR_PTR'

I think this is a valid change, though I think commit message is not informative enough in this case. the problem is that opp.h defines a set of empty access functions for use when CPUFREQ is not defined, which is the case you seem to be hitting. it is not restricted to zoom3 defconfig.

If you could rephrase the commit message accordingly, it would be helpful.


Signed-off-by: Manjunatha GK <manjugk@xxxxxx>
Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
---
 arch/arm/plat-omap/include/plat/opp.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat-omap/include/plat/opp.h
index dc9a0d9..6b38a20 100644
--- a/arch/arm/plat-omap/include/plat/opp.h
+++ b/arch/arm/plat-omap/include/plat/opp.h
@@ -15,6 +15,7 @@
 #define __ASM_ARM_OMAP_OPP_H
#include <linux/cpufreq.h>
+#include <linux/err.h>
#ifdef CONFIG_ARCH_OMAP3
 enum opp_t {


--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux