On Wed, 2010-04-14 at 12:55 +0200, ext Koen Kooi wrote: > Op 14 apr 2010, om 12:43 heeft Tomi Valkeinen het volgende geschreven: > > > On Tue, 2010-04-13 at 17:24 +0200, ext Koen Kooi wrote: > >> Op 12 apr 2010, om 13:15 heeft Grazvydas Ignotas het volgende geschreven: > >> > >>> On Mon, Apr 12, 2010 at 1:37 PM, Tomi Valkeinen > >>> <tomi.valkeinen@xxxxxxxxx> wrote: > >>>> > >>>> On Mon, 2010-04-12 at 11:19 +0200, ext Koen Kooi wrote: > >>>>> This patch adds DSS2 support to the beagleboard boardfile. DVI and TV-out are supported. > >>>>> > >>>>> Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxxxxxxxx> > >>>> > >>>> Fiddling with TWL directly in tv enable/disable functions is a bit ugly, > >>>> but I'm not sure if there's a better way for that. Otherwise: > >>> > >>> It's only toggling VDAC supply, don't we already do that in DSS2 core? > >>> I think beagle_panel_enable_tv and beagle_panel_disable_tv can be > >>> simply removed. > >> > >> I can send an updated patch with those bits removed if needed. Tomi? > > > > Yes, all the comments from Grazvydas were valid. > > OK, sent. There were other comments also, about the regulators at least. Those should be looked at too. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html