On 04/14/10 10:55, Koen Kooi wrote: > This patch adds DSS2 support to the beagleboard boardfile. DVI and TV-out are supported. > > Changes since v1: > * removed beagle_panel_enable_tv() and beagle_panel_disable_tv() > > Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxxxxxxxx> > --- > arch/arm/mach-omap2/board-omap3beagle.c | 130 ++++++++++++++++++++++++------- > 1 files changed, 103 insertions(+), 27 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c > index 962d377..534316c 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -39,6 +39,7 @@ > <snip> > + > +static struct platform_device beagle_dss_device = { > + .name = "omapdss", > + .id = -1, > + .dev = { > + .platform_data = &beagle_dss_data, > + }, > +}; > + > +static struct regulator_consumer_supply beagle_vdac_supply = { > + .supply = "vdda_dac", > + .dev = &beagle_dss_device.dev, > +}; Shouldn't we use the REGULATOR_SUPPLY macro? see commit ed6543243a1c557dbe2005a86f6d > + > +static struct regulator_consumer_supply beagle_vdvi_supply = { > + .supply = "vdds_dsi", > + .dev = &beagle_dss_device.dev, > +}; Here too. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html