On Thu, Apr 08, 2010 at 07:43:44AM +0200, ext Shilimkar, Santosh wrote:
-----Original Message-----
From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Felipe
Balbi
Sent: Thursday, April 08, 2010 10:12 AM
To: Arce, Abraham
Cc: linux-omap@xxxxxxxxxxxxxxx
Subject: Re: OMAP4 keypad driver
On Thu, Apr 08, 2010 at 03:16:08AM +0200, ext Arce, Abraham wrote:
>Hi,
>
>I need some help to figure out the best way to incorporate omap4 keypad in linux omap.
>
>First approach, I have a patch that creates a new file, omap4-keypad.c with the following
implementations:
>
> - Based on matrix keypac logic
> - Using hwmod framework
> - Using threaded irq
>
>Second approach, to change existing omap-keypad.c to matrix keypad
>
>Not clear on the path to follow... Thanks for your comments.
isn't that part of the twl6030 pmic ? If so you need a better name for
it, something like twl6030-keypad.c
It's not. OMAP4 has it's own keyboard controller embedded.
then why do you use threaded_irq ? If omap4 has its own keypad
controller, then sure it's memory-mapped, no ? Well, please send the
driver and we can comment further :-p
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
