Re: [PATCHV3 1/2] OMAP3: Set MPU and IVA bypass Clock Divider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 1 Apr 2010, Vishwanath BS wrote:

> DSP usage at VDD1 OPP1 and OPP2 with Smartreflex enabled and any MM
> UCs running DSP codec was earlier restricted as DSP crashed.
> The root cause is wrong DPLL1/DPLL2 Bypass clock at VDD1 OPP1 and OPP2.
> The solution is to make sure DPLL1/DPLL2 bypass clock is always less
> than maximum supported frequency for the specific OPP.
> 
> Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx>
> ---
>  arch/arm/mach-omap2/clock3xxx_data.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c
> index d5153b6..d8e57a6
> --- a/arch/arm/mach-omap2/clock3xxx_data.c
> +++ b/arch/arm/mach-omap2/clock3xxx_data.c

...

> @@ -3597,5 +3601,13 @@ int __init omap3xxx_clk_init(void)
>  	sdrc_ick_p = clk_get(NULL, "sdrc_ick");
>  	arm_fck_p = clk_get(NULL, "arm_fck");
>  
> +	/* Set the bypass clock dividers for DPLL1 and DPLL2 */
> +	if (cpu_is_omap3630()) {
> +		clk_set_rate(&dpll1_fck, 400000000/2);
> +		clk_set_rate(&dpll2_fck, 400000000/2);
> +	} else {
> +		clk_set_rate(&dpll1_fck, 332000000/4);
> +		clk_set_rate(&dpll2_fck, 332000000/4);
> +	}

This code is highly OPP-specific.  Why is this code needed here?  
Shouldn't the code in resource34xx.c be sufficient?


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux