> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, March 04, 2010 11:03 PM > To: Gupta, Ajay Kumar > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: usb_nop_xceiv_register() missing when OTG built as modules > > "Gupta, Ajay Kumar" <ajay.gupta@xxxxxx> writes: > > >> -----Original Message----- > >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > >> owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman > >> Sent: Thursday, March 04, 2010 5:39 AM > >> To: linux-omap@xxxxxxxxxxxxxxx > >> Subject: usb_nop_xceiv_register() missing when OTG built as modules > >> > >> This just started happening with v2.6.33. > >> > >> On OMAP3EVM, usb_nop_xceiv_register() is called in the board file, > >> but if USB gadget support is built as a module, this causes a link > >> error (below) > > > > Kevin, > > > > usb_nop_xceiv_register() is defined at drivers/usb/otg/nop-usb-xceiv.c > file > > which gets compiled if CONFIG_NOP_USB_XCEIV=y. > > > > I think you have enabled CONFIG_NOP_USB_XCEIV as module? > > Yes, I did that intentionally. I *want* USB compiled as a module. If > I do that, the build fails, and that's a bug that needs to be fixed. USB can still be compiled as module without any error if we choose CONFIG_NOP_USB_XCEIV=y. Any reason why you want NOP transceiver also as module ? -Ajay > > Kevin > > > > > >> > >> This is obviously broken, and this hook needs to be fixed to work when > >> called as a module. > >> > >> To reproduce, start with omap3_defconfig and change both USB host > >> and gadget to be built as modules. > >> > >> Kevin > >> > >> > >> [...] > >> LD .tmp_vmlinux1 > >> arch/arm/mach-omap2/built-in.o: In function `omap3_evm_init': > >> /opt/home/khilman/work.local/kernel/omap/dev/arch/arm/mach-omap2/board- > >> omap3evm.c:686: undefined reference to `usb_nop_xceiv_register' > >> arch/arm/mach-omap2/built-in.o: In function `omap_4430sdp_init': > >> /opt/home/khilman/work.local/kernel/omap/dev/arch/arm/mach-omap2/board- > >> 4430sdp.c:143: undefined reference to `usb_nop_xceiv_register' > >> make[1]: *** [.tmp_vmlinux1] Error 1 > >> make: *** [sub-make] Error 2 > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-omap" > in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html