> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Monday, February 15, 2010 11:19 PM > To: Paul Walmsley > Cc: Varadarajan, Charulatha; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/4 RFC]OMAP:GPIO: Make GPIO an early init device > > * Paul Walmsley <paul@xxxxxxxxx> [100214 17:38]: > > On Fri, 12 Feb 2010, Paul Walmsley wrote: > > > > > On Fri, 12 Feb 2010, Varadarajan, Charulatha wrote: > > > > > > > OMAP: Convert GPIO into a early driver > > > > > > The above patch appears to be missing. Could you please re-send? > > > > This patch was too big for the mailing list, so it's been posted here: Thanks Paul. > > > > http://www.pwsan.com/omap/patches/gpio/0002-OMAP-GPIO-split-omap1-and- > omap2.patch > > What, make two almost identical copies of the shared code? No way! > Instead, please keep the common code under plat-omap: > > arch/arm/plat-omap/gpio.c > > Then implement the processor specific functions: > > arch/arm/mach-omap1/gpio.c > arch/arm/mach-omap2/gpio.c > arch/arm/mach-omap2/gpio24xx.c > arch/arm/mach-omap2/gpio44xx.c > > Then have a subsys_initcall in processor specific implementation > that sets the function pointers in the common code. > Tony, The current gpio.c has functions with code similar as mentioned below: { #ifdef CONFIG_ARCH_OMAP1 Get the reg offset for OMAP1 #endif #ifdef CONFIG_ARCH_OMAP15XX Get the reg offset for OMAP15XX #endif #ifdef CONFIG_ARCH_OMAP16XX Get the reg offset for OMAP16XX #endif #if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850) Get the reg offset for this OMAP #endif #if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3) Get the reg offset for OMAP2&3 #endif #if defined(CONFIG_ARCH_OMAP4) Get the reg offset for OMAP4 #endif Read/write the register } If function pointers are used in common code (plat-omap/gpio.c), the API's in this file would essentially do nothing but invoke these pointers. IMHO this is simply adding one unnecessary level of indirection. Please correct me if I am missing out something. > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
