Re: [PATCH 0/4 RFC]OMAP:GPIO: Make GPIO an early init device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Paul Walmsley <paul@xxxxxxxxx> [100214 17:38]:
> On Fri, 12 Feb 2010, Paul Walmsley wrote:
> 
> > On Fri, 12 Feb 2010, Varadarajan, Charulatha wrote:
> > 
> > >   OMAP: Convert GPIO into a early driver
> > 
> > The above patch appears to be missing.  Could you please re-send?
> 
> This patch was too big for the mailing list, so it's been posted here:
> 
> http://www.pwsan.com/omap/patches/gpio/0002-OMAP-GPIO-split-omap1-and-omap2.patch

What, make two almost identical copies of the shared code? No way!
Instead, please keep the common code under plat-omap:

arch/arm/plat-omap/gpio.c

Then implement the processor specific functions:

arch/arm/mach-omap1/gpio.c
arch/arm/mach-omap2/gpio.c
arch/arm/mach-omap2/gpio24xx.c
arch/arm/mach-omap2/gpio44xx.c

Then have a subsys_initcall in processor specific implementation
that sets the function pointers in the common code.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux