> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Saturday, February 13, 2010 3:20 AM > To: Varadarajan, Charulatha > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxxxxxxxxxxxxxxx; > tony@xxxxxxxxxxx; Nayak, Rajendra > Subject: Re: [PATCH 0/2 RFC]OMAP3430: hwmod FW for GPIO > > On Fri, 12 Feb 2010, Varadarajan, Charulatha wrote: > > > This patch series makes the OMAP3430 GPIO module > > use hwmod framework. > > > > This patch series applies on top of pm branch > > and it requires my previous patch set which converts > > GPIO into an early init device. > > > > They are boot tested on SDP 3430 and compile tested > > for OMAP 2420 and 2430. > > > > Charulatha V (2): > > OMAP3: hwmod: add GPIO hwmods for OMAP3430 > > OMAP3: hwmod: Adapt HWMOD FW for GPIO OMAP3430 > > > > arch/arm/mach-omap2/gpio.c | 901 ++++--------------------- > ------- > > arch/arm/mach-omap2/omap_hwmod_34xx.h | 410 +++++++++++++++ > > arch/arm/plat-omap/include/plat/gpio.h | 25 +- > > NAK. Your series just broke GPIO for all non-OMAP3430 chips. Paul, This patch series is only RFC as the changes are huge. I would like to get comments for the approach taken for HWMOD implementation for GPIO. After aligning with everyone, I would extend my patches to support non-OMAP3430 chips too. -Charulatha > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html