Re: [PATCHV4 2/4] OMAP3: Remove FreqSel for 3630

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Vishwanath,

On Thu, 7 Jan 2010, Vishwanath BS wrote:

> Frequency Selection field is no longer valid for OMAP3630. So remove
> references to that.

The code in the patch is fine, but this patch description doesn't seem to 
have anything to do with the code.  Please fix and resend.

> 
> Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx>
> ---
>  arch/arm/mach-omap2/dpll.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/dpll.c b/arch/arm/mach-omap2/dpll.c
> index 4f5570e..e3c6008 100755
> --- a/arch/arm/mach-omap2/dpll.c
> +++ b/arch/arm/mach-omap2/dpll.c
> @@ -346,8 +346,8 @@ int omap3_noncore_dpll_program(struct clk *clk, u16 m, u8 n, u16 freqsel)
>  	/* 3430 ES2 TRM: 4.7.6.9 DPLL Programming Sequence */
>  	_omap3_noncore_dpll_bypass(clk);
>  
> -	/* Set jitter correction */
> -	if (!cpu_is_omap44xx()) {
> +	/* Set jitter correction. No jitter correction for OMAP4 and 3630 */
> +	if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
>  		v = __raw_readl(dd->control_reg);
>  		v &= ~dd->freqsel_mask;
>  		v |= freqsel << __ffs(dd->freqsel_mask);
> @@ -429,8 +429,8 @@ int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate)
>  		if (dd->last_rounded_rate == 0)
>  			return -EINVAL;
>  
> -		/* No freqsel on OMAP4 */
> -		if (!cpu_is_omap44xx()) {
> +		/* No freqsel on OMAP4 and OMAP3630 */
> +		if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
>  			freqsel = _omap3_dpll_compute_freqsel(clk,
>  						dd->last_rounded_n);
>  			if (!freqsel)
> -- 
> 1.5.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux