RE: [PATCHV4 3/4] OMAP3: Introduce 3630 DPLL4 HSDivider changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Vishwanath,

On Fri, 8 Jan 2010, Sripathy, Vishwanath wrote:

> > From: Paul Walmsley [mailto:paul@xxxxxxxxx]
> > > On Thu, 7 Jan 2010, Vishwanath BS wrote:
> > >
> > > +static struct clk dpll4_ck_3630 __initdata = {
> > 
> > Marking these as __initdata will crash the system for DVFS changes after
> > the kernel boots.  Please fix.
> 
> Sorry I did not understand why it should crash the system for DVFS? 
> dpll4_ck_3630 is not used anywhere after it's values are copied into 
> dpll4_ck as part of clock_init. Same is the case with others.

Sorry, you're right - your code copies the entire structure and not just 
the pointer. 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux