Olof Johansson wrote: > Having one combined defconfig that is the superset of the individual > defconfigs for OMAP3 platforms is useful for easily finding build > errors. Not to mention convenient as a base if you want to boot several > platforms with a single kernel image. > > Signed-off-by: Olof Johansson <olof@xxxxxxxxx> > > > --- > > Tony, I noticed linux-next doesn't build many of the OMAP defconfigs, > and a handful of them won't build to date. I suggest adding this config, > and I'll as Stephen Rothwell to add it as one of the configs that are > tested (and build errors reported) for every release. > > He's reluctant to add too many individual configs since it adds time to > each cycle, but one more can surely be acceptable. > Good idea. Kevin does something similar with the pm branch. There's an omap3_pm_defconfig. A few minor comments below. > > -Olof > <snip> > +CONFIG_USER_SCHED=y > +# CONFIG_CGROUP_SCHED is not set > +# CONFIG_CGROUPS is not set > +CONFIG_SYSFS_DEPRECATED=y > +CONFIG_SYSFS_DEPRECATED_V2=y Would you consider getting rid of these two? There was a patch recently to remove these from the other omap defconfigs, so this would be one inconsistency between them. <snip> > +# Miscellaneous USB options > +# > +CONFIG_USB_DEVICEFS=y > +CONFIG_USB_DEVICE_CLASS=y > +# CONFIG_USB_DYNAMIC_MINORS is not set > +CONFIG_USB_SUSPEND=y > +CONFIG_USB_OTG=y > +CONFIG_USB_OTG_WHITELIST=y > +CONFIG_USB_OTG_BLACKLIST_HUB=y This removes the ability to connect all devices to MUSB in host mode. (Most flash drives would not be on the whitelist). Also, blacklisting hubs means you can't use an external hub either - which is commonly used with beagle and other similar boards. <snip> > +# OMAP 343x high speed USB support > +# > +# CONFIG_USB_MUSB_HOST is not set > +# CONFIG_USB_MUSB_PERIPHERAL is not set > +CONFIG_USB_MUSB_OTG=y > +CONFIG_USB_GADGET_MUSB_HDRC=y > +CONFIG_USB_MUSB_HDRC_HCD=y > +CONFIG_MUSB_PIO_ONLY=y And this would remove the MUSB DMA support on these boards. I think you should make this n. It's always possible to disable dma by adding a parameter "musb_hdrc.use_dma=n" to the kernel command line - Anand -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
