RE: [PATCH v2 1/1] omap: serial: fix non-empty uart fifo read abort

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




>-----Original Message-----
>From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx]
>Sent: Tuesday, November 17, 2009 7:00 PM
>To: Pandita, Vikram
>Cc: linux-omap@xxxxxxxxxxxxxxx; Pandita, Vikram
>Subject: Re: [PATCH v2 1/1] omap: serial: fix non-empty uart fifo read abort
>
>On Tue, 17 Nov 2009 17:39:11 -0600
>Vikram Pandita <vikram.pandita@xxxxxx> wrote:
>
>> OMAP3630 and OMAP4430 UART IP blocks have a restriction wrt RX FIFO.
>> Empty RX fifo read causes an abort. OMAP1/2/3 do not have this restriction.
>>
>> Overrigt the default 8250 read handler: mem_serial_in()
>> by a custom handler: serial_in_8250()
>>
>> serial_in_8250() makes sure that RX fifo is not read when empty,
>> on omap4 and 3630 silicons only
>>
>> tested on zoom3(3630) board
>
>Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
>
>(Please push it via the OMAP tree as its now OMAP specific)

Thanks for the suggestion that made it 8250 independent.
I am scared to touch this driver :)

Yes I would get this patch upstream via Tony now.
I am getting some minor review comments on linux-omap, will fix and repost.


>
>
>Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux