>-----Original Message----- >From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx] >Sent: Tuesday, November 17, 2009 3:26 PM >To: Pandita, Vikram >Cc: linux-serial@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Pandita, >Vikram; Shilimkar, Santosh >Subject: Re: [PATCH 1/2] serial: 8250: add UPF_NO_EMPTY_FIFO_READ flag > >On Tue, 17 Nov 2009 15:16:55 -0600 >Vikram Pandita <vikram.pandita@xxxxxx> wrote: > >> OMAP3630 and OMAP4430 UART IP blocks have a restriction wrt RX FIFO. >> Empty RX fifo read causes an abort. OMAP1/2/3 do not have this restriction. > >Nothing wrong with the requirement but I think it would keep 8250.c a lot >cleaner if you implemented that in the serial_in method for the >OMAP3630/4430. It would also mean anyone adding a UART_RX or any cases >you miss don't break in future Agree. Was contemplating this change in beginning, but lost that train of thought. Thx for your review time. > >This is especially true now as you can pass a private >serial_in/serial_out method in the port register function. Our requirement is to over-right the serial_in for now. Is it fine to just add serial_in over-load or do you suggest both in/out? > >Care to submit an alternate patch doing it that way, or see any reason >for not ? Working on it right away. See my patch in an hours time. > >Alan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
