Tuesday 17 November 2009 11:45:53 Janusz Krzysztofik napisał(a): > Tuesday 17 November 2009 02:24:35 Tony Lindgren napisał(a): > > * Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> [091116 16:38]: > > > Tuesday 17 November 2009 01:16:58 Tony Lindgren napisał(a): > > > > * Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> [091116 15:13]: > > > > > diff -uprN a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c > > > > > --- a/arch/arm/plat-omap/dma.c 2009-11-14 23:48:41.000000000 +0100 > > > > > +++ b/arch/arm/plat-omap/dma.c 2009-11-16 23:49:30.000000000 +0100 > > > > > @@ -36,6 +36,10 @@ > > > > > > > > > > #include <plat/tc.h> > > > > > > > > > > +#ifdef CONFIG_ARCH_OMAP1 > > > > > +#include <mach/lcdc.h> > > > > > +#endif > > > > > + > > > > > #undef DEBUG > > > > > > > > > > #ifndef CONFIG_ARCH_OMAP1 > > > > > @@ -1124,9 +1128,11 @@ int omap_dma_running(void) > > > > > * On OMAP1510, internal LCD controller will start the transfer > > > > > * when it gets enabled, so assume DMA running if LCD enabled. > > > > > */ > > > > > +#ifdef CONFIG_ARCH_OMAP1 > > > > > if (cpu_is_omap1510()) > > > > > - if (omap_readw(0xfffec000 + 0x00) & (1 << 0)) > > > > > + if (omap_readw(OMAP_LCDC_CONTROL) & OMAP_LCDC_CTRL_LCD_EN) > > > > > return 1; > > > > > +#endif > > > > > > > > > > /* Check if LCD DMA is running */ > > > > > if (cpu_is_omap16xx()) > > > > > > > > Hmm, this is getting complicated... How about just add function to > > > > drivers/video/omap/lcdc.c for something like omap_lcdc_get_status() > > > > or similar? > > > > > > Good idea. > > ... for a function itself, but not for putting it there, since omapfb, that > lcdc is a part of, can be build as a module :). Hmm, looks like building omapfb as a module is broken (Kconfig/Makefile allow for this), at least for OMAP1. Anyway, I don't like the idea of putting something that depends on drivers into arch (even if it happened to be one of my initial concepts). Thanks, Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
