From: Menon, Nishanth Sent: Friday, October 23, 2009 2:46 PM > Aguirre Rodriguez, Sergio Alberto had written, on 10/23/2009 02:39 PM, > the following: > > Vikram, > > > > Just some comments I came across below. > > > > From: linux-omap-owner@xxxxxxxxxxxxxxx [linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Pandita, Vikram > > Sent: Friday, October 23, 2009 2:23 PM > >> Add machine type support for zoom3 board > >> Add board type in Kconfig and Makefile > >> Reused the zoom board file for zoom2 and zoom3 > >> > >> Signed-off-by: Vikram Pandita <vikram.pandita@xxxxxx> > >> --- > >> arch/arm/mach-omap2/Kconfig | 4 ++++ > >> arch/arm/mach-omap2/Makefile | 3 +++ > >> arch/arm/mach-omap2/board-zoom2-zoom3.c | 4 ++++ > >> 3 files changed, 11 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > >> index 8685df5..fa20996 100644 > >> --- a/arch/arm/mach-omap2/Kconfig > >> +++ b/arch/arm/mach-omap2/Kconfig > >> @@ -97,6 +97,10 @@ config MACH_OMAP_ZOOM2 > >> bool "OMAP3 Zoom2 board" > > > > How about also clarifying here ^^ the chip version: > > > > bool "OMAP3430 Zoom2 board" > > > > I mean, just to stick to the convention you're putting below. > > > >> depends on ARCH_OMAP3 && ARCH_OMAP34XX > >> > >> +config MACH_OMAP_ZOOM3 > >> + bool "OMAP3630 Zoom3 board" > >> + depends on ARCH_OMAP3 && ARCH_OMAP34XX > > > > Shouldn't this be: > > > > depends on ARCH_OMAP3 && ARCH_OMAP36XX > > > is there an ARCH_OMAP36XX? i believe not ;).. > Hmm... (Had this discussion before, not going there...) > > Linux-OMAP build allows for both boards to be defined at the same time.. > so in theory you could have a single uImage. the strategy followed here > will fail it.. since the board file is the same one.. it could be made > to work though.. > Not with this approach :) How about making board-zoom3.c separate from board-zoom2.c, and do a smarter way to share as much as possible? To modularize, I'll suggest taking a look at RX51 board files. That way you can have board-zoom2.c, board-zoom3.c, with the modules shared accordingly in Makefile. Camera is already doing that ;) What do you think? Regards, Sergio -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
