On Wed, Oct 14, 2009 at 11:52 AM, G, Manjunath Kondaiah <manjugk@xxxxxx> wrote: > You can acheive the same using only enum with following: > > #define OMAP_RTC_REGISTER_SIZE (cpu_is_omap7xx()?1:4) > #define rtc_read(reg) > omap_readb(OMAP_RTC_BASE + (reg * OMAP_RTC_REGISTER_SIZE)) That was my first instinct too, but then I thought that one of the register offsets wasn't related by a factor of 4 (when I made the patch originally it was ~ 2am and I was very tired), which convinced me to do a quick & easy static array implementation. Thanks for your suggestion. Regarding the 50 -> 35 change, I think it's clearly safe to do. I have no objections. C -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html