Hello Aaro! > -----Original Message----- > From: Aaro Koskinen [mailto:aaro.koskinen@xxxxxxxxx] > Sent: Tuesday, October 13, 2009 4:52 AM > To: Sonasath, Moiz > Cc: ben-linux@xxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux- > omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH RESEND] I2C: OMAP: Add missing wakeup events > > Hello, > > Sonasath, Moiz wrote: > >> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> > >> > >> Include wake up events for receiver overflow and transmitter > >> underflow in OMAP_I2C_WE_REG configuration. Also fix a small > >> typo. > >> > >> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> > >> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxxxxx> > >> --- > >> drivers/i2c/busses/i2c-omap.c | 5 ++++- > >> 1 files changed, 4 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c- > omap.c > >> index 827da08..34ea9ed 100644 > >> --- a/drivers/i2c/busses/i2c-omap.c > >> +++ b/drivers/i2c/busses/i2c-omap.c > >> @@ -92,8 +92,10 @@ > >> #define OMAP_I2C_STAT_AL (1 << 0) /* Arbitration lost int ena */ > >> > >> /* I2C WE wakeup enable register */ > >> -#define OMAP_I2C_WE_XDR_WE (1 << 14) /* TX drain wakup */ > >> +#define OMAP_I2C_WE_XDR_WE (1 << 14) /* TX drain wakeup */ > >> #define OMAP_I2C_WE_RDR_WE (1 << 13) /* RX drain wakeup */ > >> +#define OMAP_I2C_WE_ROVR_WE (1 << 11) /* RX overflow wakeup */ > >> +#define OMAP_I2C_WE_XUDF_WE (1 << 10) /* TX underflow wakeup */ > > > > These bits are not documented in OMAP3430, they are reserved. How can > they be used? > > Hmm, that's a valid point. I will have to check if I can find more info on > the background of this patch. AFAIK, these bits have been introduced in OMAP3630 as it has a new IP block for I2C. But these bits are reserved bits for OMAP3430. > > A. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
