Kevin Hilman said the following on 10/01/2009 06:58 PM: > From: Rajendra Nayak <rnayak@xxxxxx> > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxx> > --- > arch/arm/plat-omap/gpio.c | 92 ++++++++++++++++++++++++++++++++ > arch/arm/plat-omap/include/mach/gpio.h | 3 +- > 2 files changed, 94 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c > index b0c7361..9850ade 100644 > --- a/arch/arm/plat-omap/gpio.c > +++ b/arch/arm/plat-omap/gpio.c > + > +/* restore the required registers of bank 2-6 */ > +void omap3_gpio_restore_context(void) > +{ > + int i; > + for (i = 1; i < gpio_bank_count; i++) { > + struct gpio_bank *bank = &gpio_bank[i]; > + __raw_writel(gpio_context[i].sysconfig, > + bank->base + OMAP24XX_GPIO_SYSCONFIG); > + __raw_writel(gpio_context[i].irqenable1, > + bank->base + OMAP24XX_GPIO_IRQENABLE1); > + __raw_writel(gpio_context[i].irqenable2, > + bank->base + OMAP24XX_GPIO_IRQENABLE2); > do you want to write to the IRQENABLE register even before configuring the rest of the registers (such as data direction etc? usually my understanding was: configure the device, enable the irq.. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html