On Tue, Feb 13, 2024 at 7:36 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Adam Ford <aford173@xxxxxxxxx> [240213 13:29]: > > On Tue, Feb 13, 2024 at 7:02 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > > > * Tony Lindgren <tony@xxxxxxxxxxx> [240213 12:56]: > > > > * Adam Ford <aford173@xxxxxxxxx> [240213 12:41]: > > > > > The sdhci driver has been around for several years, and it supports > > > > > the OMAP3 family. Instead of using the older driver, let's finally > > > > > migrate to the newer one. > > > > > > > > I think we also should do these to avoid incomplete conversion: > > > > > > > > - ti,dual-volt property can be dropped > > > > > > > > - ti,non-removable should become non-removable > > > > I'll do a more comprehensive search for these flags. When I did my > > testing on the AM3517, I didn't notice these, but I see now that > > others might. I'll do a multi-patch series to first address the > > multi-block, then omap3-ldp.dts, then migrate the omap3.dtsi to the > > new driver while dropping the flags, and lastly update the individual > > boards accordingly. I just have one question below. > > OK sounds good to me :) > > > > > - ti,omap3-pre-es3-hsmmc probably should not be needed with sdhci > > > > > > Hmm actually we may need to set SDHCI_QUIRK_NO_MULTIBLOCK for > > > compatible ti,omap3-pre-es3-hsmmc. > > > > Should I update the driver and binding to add ti,omap3-pre-es3-sdhci > > to set that flag, or should we create a boolean (maybe > > 'ti,sdhci-no-multiblock') to the device tree options for that driver? > > Probably best to set up some sdhci generic property for it that then > sets SDHCI_QUIRK_NO_MULTIBLOCK. Sounds good. I'll try to work on this tonight, but it might be a day or two before I get the more comprehensive update out. Hopefully in the meantime, people may respond with other comments too. I also want to retest my OMAP35 and DM37 boards. It's been since kernel 6.1 since I tested them all. adam > > Regards, > > Tony
