Re: [PATCH 2/2] power: supply: cpcap-charger: Allow changing constant charge voltage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 2/2] power: supply: cpcap-charger: Allow changing constant charge voltage
From: Tony Lindgren <tony@xxxxxxxxxxx>
Date: Wed, 16 Oct 2019 15:38:47 -0700
Cc: Sebastian Reichel <sre@xxxxxxxxxx>, linux-pm@xxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, Merlijn Wajer <merlijn@xxxxxxxxxx>
In-reply-to: <20191013113111.GD5653@amd>
References: <20191009210141.10037-1-tony@atomide.com> <20191009210141.10037-3-tony@atomide.com> <20191013113111.GD5653@amd>
User-agent: Mutt/1.12.1 (2019-06-15)

* Pavel Machek <pavel@xxxxxx> [191013 11:31]:
> Would it be better to return 0 for < 3.8V values?

No, it's setting the charge current to zero that
controls the charger.

> > +	case 4100000 ... 4120000 - 1: return 4120000;
> 
> I believe this should be 4100000.

Thanks for spotting that one.

Regards,

Tony

References:
- [PATCHv2 0/2] cpcap charger and battery changes to deal with dropped voltage
  - From: Tony Lindgren
- [PATCH 2/2] power: supply: cpcap-charger: Allow changing constant charge voltage
  - From: Tony Lindgren
- Re: [PATCH 2/2] power: supply: cpcap-charger: Allow changing constant charge voltage
  - From: Pavel Machek

Prev by Date: Re: [PATCH 1/2] power: supply: cpcap-battery: Fix handling of lowered charger voltage
Next by Date: [PATCHv3 0/2] cpcap charger and battery changes to deal with dropped voltage
Previous by thread: Re: [PATCH 2/2] power: supply: cpcap-charger: Allow changing constant charge voltage
Next by thread: [PATCH 0/5] cpcap battery simplification and calibrate support
Index(es):
- Date
- Thread

[Index of Archives] [Linux Arm (vger)] [ARM Kernel] [ARM MSM] [Linux Tegra] [Linux WPAN Networking] [Linux Wireless Networking] [Maemo Users] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux SCSI]

Powered by Linux