* Pavel Machek <pavel@xxxxxx> [191013 11:30]: > > +static int cpcap_battery_set_property(struct power_supply *psy, > > + enum power_supply_property psp, > > + const union power_supply_propval *val) > > +{ > > + struct cpcap_battery_ddata *ddata = power_supply_get_drvdata(psy); > > + > > + switch (psp) { > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: > > + if (val->intval < ddata->config.info.voltage_min_design) > > + return -EINVAL; > > Is minimum design applicable here? I believe that's the lowest voltage > battery is discharged to... > > I guess we can use it if there's no more suitable limit? Yeah so it seems, and can be changed if we find something bettter. > > + ddata->config.bat.constant_charge_voltage_max_uv = val->intval; > > + > > + return cpcap_battery_update_charger(ddata, val->intval); > > + break; > > Delete the break. Sure thanks. Tony