> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, June 09, 2009 9:45 AM > To: Hald, Ulrik Bech > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/3] OMAP3:WDT:Enable IVA, SECURE and minor bugfixes > > Ulrik Bech Hald <ubh@xxxxxx> writes: > > > This patch series enables support for IVA and SECURE > > WDTs, available on omap34xx. > > For omap34xx devices the WDT will be accessible > > (when present) through: > > SECURE: /dev/watchdog1 > > MPU: /dev/watchdog2 > > IVA: /dev/watchdog3 > > > > For devices older than omap34xx only MPU WDT is present > > and will be accessible through /dev/watchdog > > I think you should make the MPU WDT the first one since it will always > be present. The reason, why I numbered them as above, is to make them match the OMAP34xx TRM WDT numbering scheme, where SECURE WDT=WDT1, MPU WDT=WDT2 and IVA WDT=WDT3. My thought was that it would introduce more confusion to change the numbers in /dev/ to something else, although I did consider your point. Do you still think I should change the numbers? > > > The series also fixes two bugs: > > > > 1) Correct timeout value is not loaded upon opening the > > watchdog device. > > > > 2) clks are not enabled when accessing registers in probe > > Can you fix these existing bugs in a separate patch before you add the > new features. Sure, no problem. > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
