>-----Original Message----- >From: ext Jean Pihet [mailto:jpihet@xxxxxxxxxx] >Sent: 09 June, 2009 11:24 >To: Kristo Tero (Nokia-D/Tampere) >Cc: khilman@xxxxxxxxxxxxxxxxxxx; paul@xxxxxxxxx; >linux-omap@xxxxxxxxxxxxxxx >Subject: Re: [RFC][PATCH] OMAP3: add support for 2 SDRAM chip selects > >On Tuesday 09 June 2009 10:14:58 Tero.Kristo@xxxxxxxxx wrote: >> >-----Original Message----- >> >From: ext Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >> >Sent: 08 June, 2009 20:24 >> >To: Jean Pihet >> >Cc: Paul Walmsley; Kristo Tero (Nokia-D/Tampere); linux-omap >> >Subject: Re: [RFC][PATCH] OMAP3: add support for 2 SDRAM >chip selects >> > >> >Jean Pihet <jpihet@xxxxxxxxxx> writes: >> >> On Monday 08 June 2009 16:59:36 Kevin Hilman wrote: >> >>> Jean Pihet <jpihet@xxxxxxxxxx> writes: >> >>> > Paul, >> >>> > >> >>> > Here is the updated patch that fixes the Overo build as well. >> >>> > Can you check it? >> >>> > >> >>> > Kevin, can you push it if it is correct? >> >>> >> >>> Can you run it through checkpatch, fix the errors and also merge >> >>> Tero's >> >>> RX51 patch if it looks good to you. >> >> >> >> Ok. I will check. The cause might be the mailer. >> >> >> >> I think we need the omap_cfg_reg calls in the RX51 board >> > >> >file as well, >> > >> >> even if the bootloader has the mux setting already right. >That way >> >> a warning will be issued in case of a faulty bootloader. >Do you agree? >> > >> >I agree. >> >> Well, this is ok for me too as it does not really change anything. I >> will voice my opinion here though. :) >> >> I find it somewhat weird that we take care of two pads in >this fashion >> out of ~350 or so, where in most cases we just assume that the pads >> are configured properly by the boot loader. Should we do the >same for >> every pad? >Got your point. This omap_cfg_reg throws a warning if the pad >is incorrectly configured. The goal is to better track the >problem in case of a wrong/older bootloader. In the ideal >world the bootloader and kernel should match and do it all right! > >> Does the kernel even boot if the CKE signals are configured >> incorrectly? I would guess the boot loader will fail to load the >> kernel image into SDRAM in that case. >The kernel boots fine in that case, only the SDRAM contents >are not preserved when going to low power mode. Ok, in this case it sounds ok to me also as it might generate hard to track bugs. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
