* Adam Ford <aford173@xxxxxxxxx> [170128 08:25]: > On Thu, Jan 26, 2017 at 10:06 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Adam Ford <aford173@xxxxxxxxx> [170126 07:58]: > >> On Thu, Jan 26, 2017 at 9:40 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > >> > * Woodruff, Richard <r-woodruff2@xxxxxx> [170126 07:14]: > >> >> > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > >> >> > Sent: Thursday, January 26, 2017 9:04 AM > >> >> > >> >> > Well we do have off mode during idle working for quite a few omap3 based > >> >> > boards just fine. And nothing prevents adding board specific > >> >> > >> >> Sure. > >> >> > >> >> > I recall playing with a SDIO WLAN card in MMC1 that I needed something > >> >> > like this to keep the card enabled during off mode as otherwise VMMC1 > >> >> > would get scaled down to 1.8V during idle. > >> >> > >> >> That seems very possible. As I recall there are 3 power provider groups P1/P2/P3 in that PMIC. Typically the processor is one, a modem is a two, and something like a wlan can be powered on 3. It depends on the board setup. > >> >> > >> >> When the processor signals an event to the PMIC it will run the script which then sends commands to each group. Some of the PMICs had a lot of programmable options and could get complex. PMICs typically mated with boards in the last few years tended to be a bit less flexible and they cost-removed the SRAM and just have fixed OTP. > >> > > >> > Looking at omap3_wrst_seq[], maybe adding just one of the following lines > >> > to does the trick for reboot: > >> > > >> > TWL_RESOURCE_RESET(RES_VMMC1), > >> > > >> > or > >> > > >> > TWL_RESOURCE_ON(RES_VMMC1), > >> > > >> > >> Tony - > >> > >> Should I try his suggestion or your patch or both? > > > > Well whatever works :) We should narrow this down as it sounds like > > it can affects other devices too booting from MMC. > > > >> I am willing to try both. Since there are two options for the > >> omap3_wrst_seq (TWL_RESOURCE_RESET and TWL_RESOURCE_ON) do you have a > >> recommendation on which one I should do there? > > > > Try the TWL_RESOURCE_RESET(RES_VMMC1) first and then hopefully the > > bootrom or MLO will be able to power it on after reboot. > > > > That did it! It works and I have been able to successfully reboot > without issue and the power consumption seems back to normal. Hey good to hear! > At the risk of breaking someone else's board, should I prepare a patch > to add that line to the wrst sequence or do you think something else > should be reworked first? That should be pretty safe thing to do AFAIK. So please do a proper patch and send it to the MFD maintainer. Probably the reason it has not been noticed earlier is many devices have u-boot on NAND. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
