On 12/08/2016 05:55 PM, Tony Lindgren wrote: > * Grygorii Strashko <grygorii.strashko@xxxxxx> [161208 15:38]: >> On 12/08/2016 04:57 PM, Tony Lindgren wrote: >>> Seems to work based on few boot tests. Probably both should be applied, >>> my original patch to prevent spurious interrupts before things are >>> initialized, >> >> you patch - do you mean disable irq or clean up >> irq status regs before requesting irq? for me, more logical is to >> clean up irq status regs. > > What I originally posted in this thread, clear irq registers > before requesting irq. > >> this to disable interrupts before pm_runtime_suspend() >>> on exit path: >>> >>> Tested-by: Tony Lindgren <tony@xxxxxxxxxxx> >> >> So, you wanna me to send this as patch or wish to squash in yours? >> (I'll be able to do this only tomorrow) > > I think this should be a separate patch for the exit path. > Actually, It seems correct solution will be to switch back from devm_request_threaded_irq() to just request_threaded_irq(), because similar problem can happen with dwc3_omap_remove() - there are no guarantee that there will be no IRQ handler running when dwc3_omap_remove() is executed and dwc3_omap_disable_irqs() will not help with that. -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
