Hi Tony, On 08/12/16 05:21, Tony Lindgren wrote: > Somehow starting with v4.9-rc7 there have been imprecise > external aborts on omap5-uevm dwc3 controller. I have not been > able to bisect what exactly triggered this as it does not always > happen. It seems that something changed with probing that > now exposes the issue: > > Unhandled fault: imprecise external abort (0x1406) at 0x00000000 > ... > PC is at dwc3_omap_interrupt_thread+0x20/0x80 > LR is at irq_thread_fn+0x1c/0x54 > ... > [<c0989fa8>] (dwc3_omap_interrupt_thread) from [<c038a4d8>] > (irq_thread_fn+0x1c/0x54) > [<c038a4d8>] (irq_thread_fn) from [<c038a7b0>] (irq_thread+0x12c/0x1f0) > [<c038a7b0>] (irq_thread) from [<c035d6f0>] (kthread+0xdc/0xf4) > [<c035d6f0>] (kthread) from [<c0307d78>] (ret_from_fork+0x14/0x3c) > ... > > Unable to handle kernel paging request at virtual address ffffffec > ... > Internal error: Oops: 37 [#2] SMP ARM > PC is at kthread_data+0x4/0xc > LR is at irq_thread_dtor+0x28/0xd0 > ... > [<c035e0b4>] (kthread_data) from [<c038a5dc>] (irq_thread_dtor+0x28/0xd0) > [<c038a5dc>] (irq_thread_dtor) from [<c035bef0>] (task_work_run+0xb8/0xdc) > [<c035bef0>] (task_work_run) from [<c03448d4>] (do_exit+0x314/0xa20) > [<c03448d4>] (do_exit) from [<c030bea8>] (die+0x410/0x474) > [<c030bea8>] (die) from [<c0301350>] (do_DataAbort+0xb4/0xb8) > [<c0301350>] (do_DataAbort) from [<c030c578>] (__dabt_svc+0x58/0x80) > Exception stack(0xee777ec8 to 0xee777f10) > 7ec0: 0000014d ee6e6f10 00000034 fc020034 ee6e6f10 ee1eec00 > 7ee0: 00000000 00000000 ee6ec640 c038a4bc 00000000 00000000 00000000 ee777f18 > 7f00: c038a4d8 c0989fa8 60000013 ffffffff > [<c030c578>] (__dabt_svc) from [<c0989fa8>] (dwc3_omap_interrupt_thread+0x20/0x80) > [<c0989fa8>] (dwc3_omap_interrupt_thread) from [<c038a4d8>] (irq_thread_fn+0x1c/0x54) > [<c038a4d8>] (irq_thread_fn) from [<c038a7b0>] (irq_thread+0x12c/0x1f0) > [<c038a7b0>] (irq_thread) from [<c035d6f0>] (kthread+0xdc/0xf4) > [<c035d6f0>] (kthread) from [<c0307d78>] (ret_from_fork+0x14/0x3c) > > Fix the issue by making sure the dwc3 interrupts are disabled > before we call devm_request_threaded_irq(). > > Note that there does not seem to be issues with the dwc3 wrapper > accessing these registers even before the dwc3 core is probed. > If some of these registers are specific to the dwc3 core, we can > have IRQ disabled with irq_set_status_flags(omap->irq, IRQ_NOAUTOEN) > on start-up instead of accessing the dwc3 registers. > > Reported-by: Kevin Hilman <khilman@xxxxxxxxxxxx> > Cc: Roger Quadros <rogerq@xxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > --- > drivers/usb/dwc3/dwc3-omap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c > --- a/drivers/usb/dwc3/dwc3-omap.c > +++ b/drivers/usb/dwc3/dwc3-omap.c > @@ -511,6 +511,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) > /* check the DMA Status */ > reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG); > > + dwc3_omap_disable_irqs(omap); > + > ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt, > dwc3_omap_interrupt_thread, IRQF_SHARED, > "dwc3-omap", omap); > I'm not able to see this issue on my omap5-uevm or dra7-evm on v4.9-rc8. What u-boot are you using? Are you using usb gadget in u-boot? cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
