* vimal singh <vimalsingh@xxxxxx> [090503 22:36]: > > > On Fri, May 1, 2009 at 11:08 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Tony Lindgren <tony@xxxxxxxxxxx> [090430 11:56]: > >> * Tony Lindgren <tony@xxxxxxxxxxx> [090430 07:06]: > >> > * vimal singh <vimalsingh@xxxxxx> [090429 23:33]: > >> > > 'gpmc-onenand.c' is still confusing name. This is not going to used in > >> > > all boards anyway. > >> > > >> > Why do you think this cannot be used for all boards? > >> > > >> > The GPMC timings are totally based on the onenand chip features. > >> > >> And these two patches make omap3430sdp to work with the gpmc-onenand > >> code. Sync mode does not work, but it seems like it was never enabled > >> for sdp anyways. > >> > >> Similar patch should work for other boards too. > > > > Setting the sync_write depends on flags and processor, not just flags. > > Here's a fixed version of this patch. > OK, these both patches seems good to me... OK, thanks for looking. > Earlier I was in impression that this patch series is basically to remove > board-*-flash.c files. Since in 3430sdp boards we find out 'CS' number for > flash devices dynamically in different versions of boards. So, I was confused. Well looks like those functions are used for at least few boards, so we could have functions like gpmc_probe_onenand() and gpmc_probe_nor() functions that could be called from board-*.c files. That way we could have generic gpmc-onenand.c and gpmc-nor.c, and still do the necessary probe logic in the board-*.c files. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
