Hi,
Thanks for the review.
On Wed, Nov 23, 2016 at 12:31 AM, Alexandre Belloni
<alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> A few alignments are off but I can fix that provided you answer the
> question below:
>
Ok, could you please indicate which lines so I can fix them instead of
wasting your time?
> On 12/11/2016 at 12:07:24 +0200, Nicolae Rosia wrote :
>> /* for twl6030/32 make sure BIT_RTC_CTRL_REG_GET_TIME_M is clear */
>> - if (twl_class_is_6030()) {
>> + if (!twl_rtc->is_4030) {
>
> This changes the meaning of it. What if at some point there is a new
> part that is neither a 4030 nor an 6030?
> That will probably mean going over ths part of code again but maybe the
> odds are low and nobody cares.
Since there are only two classes, 4030 and 6030, it will work.
But you're right, it's better to retain the old logic so the changes
are minimal.
Will send V2 in a bit.
Thanks,
Nicolae
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
