Hi, A few alignments are off but I can fix that provided you answer the question below: On 12/11/2016 at 12:07:24 +0200, Nicolae Rosia wrote : > /* for twl6030/32 make sure BIT_RTC_CTRL_REG_GET_TIME_M is clear */ > - if (twl_class_is_6030()) { > + if (!twl_rtc->is_4030) { This changes the meaning of it. What if at some point there is a new part that is neither a 4030 nor an 6030? That will probably mean going over ths part of code again but maybe the odds are low and nobody cares. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html