Regards, Santosh > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of > Shilimkar, Santosh > Sent: Thursday, April 30, 2009 10:02 AM > To: Jarkko Nikula > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] OMAP: sDMA: Correct the the > omap_request_dma_chain() signature > > > -----Original Message----- > > From: Jarkko Nikula [mailto:jhnikula@xxxxxxxxx] > > Sent: Thursday, April 30, 2009 12:38 AM > > To: Shilimkar, Santosh > > Cc: linux-omap@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] OMAP: sDMA: Correct the the > > omap_request_dma_chain() signature > > > > On Wed, 29 Apr 2009 17:39:16 +0530 > > Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote: > > > > > Original OMAP DMA chaining design has chain_id as one of > > the callback > > > parameters. The below patch broke the desing. > > > > > http://git.omapzoom.org/?p=repo/omapkernel.git;a=commitdiff;h= > > 538528de0cb256f65716ab2e9613d9e920f97fe2 > > > Now callback returns logical channel number and not chain_id. > > > Hence the signature of the omap_request_dma_chain() > functions needs > > > to be corrected to avoid any confusion. > > > > > > More details are on this email thread : > > > http://marc.info/?l=linux-omap&m=122961071931459&w=2 > > > > > Thanks! And this thread where I promised to send a patch but > > never done > > it... > > > > http://marc.info/?l=linux-omap&m=122770291205164&w=2 > > > > Two comments: > > "Now callback returns logical channel number and not chain_id. " > > You mean callback gets lch instead of chain_id as an argument? > Yes. > > Change also kernel-doc function comment for omap_request_dma_chain. > > I.e. those comment lines few lines before the function itself. > Yes would do that and send the patch. There is no change needed in the documentation part since there is no description about the callback parameters. /** * @brief omap_request_dma_chain : Request a chain of DMA channels * * @param dev_id - Device id using the dma channel * @param dev_name - Device name * @param callback - Call back function * @chain_id - * @no_of_chans - Number of channels requested * @chain_mode - Dynamic or static chaining : OMAP_DMA_STATIC_CHAIN * OMAP_DMA_DYNAMIC_CHAIN * @params - Channel parameters * * @return - Succes : 0 * Failure: -EINVAL/-ENOMEM */ int omap_request_dma_chain(int dev_id, const char *dev_name, void (*callback) (int chain_id, u16 ch_status, void *data), int *chain_id, int no_of_chans, int chain_mode, struct omap_dma_channel_params params) { So no need to change the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
