> -----Original Message----- > From: Jarkko Nikula [mailto:jhnikula@xxxxxxxxx] > Sent: Thursday, April 30, 2009 12:38 AM > To: Shilimkar, Santosh > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] OMAP: sDMA: Correct the the > omap_request_dma_chain() signature > > On Wed, 29 Apr 2009 17:39:16 +0530 > Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote: > > > Original OMAP DMA chaining design has chain_id as one of > the callback > > parameters. The below patch broke the desing. > > > http://git.omapzoom.org/?p=repo/omapkernel.git;a=commitdiff;h= > 538528de0cb256f65716ab2e9613d9e920f97fe2 > > Now callback returns logical channel number and not chain_id. > > Hence the signature of the omap_request_dma_chain() functions needs > > to be corrected to avoid any confusion. > > > > More details are on this email thread : > > http://marc.info/?l=linux-omap&m=122961071931459&w=2 > > > Thanks! And this thread where I promised to send a patch but > never done > it... > > http://marc.info/?l=linux-omap&m=122770291205164&w=2 > > Two comments: > "Now callback returns logical channel number and not chain_id. " > You mean callback gets lch instead of chain_id as an argument? Yes. > Change also kernel-doc function comment for omap_request_dma_chain. > I.e. those comment lines few lines before the function itself. Yes would do that and send the patch. Regards, Santosh-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
