On Thu, 23 Apr 2009, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [090423 15:26]: > > On Thu, Apr 23, 2009 at 11:00:31AM -0700, Tony Lindgren wrote: > > > * Paul Walmsley <paul@xxxxxxxxx> [090423 01:35]: > > > > Hello Russell, > > > > > > > > On Thu, 23 Apr 2009, Russell King - ARM Linux wrote: > > > > > > > > > On Wed, Apr 22, 2009 at 08:01:29PM -0600, Paul Walmsley wrote: > > > > > > The patch also renames clk_init_one() to clk_preinit() to > > > > > > distinguish its function from clk_init() and the individual struct clk > > > > > > init functions. > > > > > > > > > > That's rather unnecessary. 'clk_init_one' is already unique. In the > > > > > long run, it's clk_init that needs to go. > > > > > > > > Even if clk_init() were to disappear, the struct clk .init function > > > > pointer would still be present. clk->init() performs a very different > > > > kind of initialization than clk_init_one(). > > > > > > I'm OK doing the rename in this fix. The original naming can cause > > > confusion while reading the code. > > > > Well I'm not, and I want to discuss it some more. And I'm sending Linus > > a pull request tonight, so I'm dropping the OMAP stuff from that. > > OK. Paul, can you please separate out the rename part into a separate > patch so we only have a minimal fix & then repost it here? > > That way we'll get the necessary fixes in and you guys can schedule > other changes for next merge window. The omap-clock-fixes branch has been updated to remove the rename. Not that this should stop the discussion, but at least this should no longer prevent these needed fixes from going upstream. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
