Re: linux-4.7.0: possible irq lock inversion dependency detected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 05, 2016 at 06:46:44AM -0700, Tony Lindgren wrote:
[snip]
> OK got it reproduced with the config you sent me, it seems to
> happen with USB_MUSB_HOST. Does the following work for you?
> Please check that devices enumerate too.

Yes, that fixes it and devices enumerate. So here's my
Tested-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>

> Regards,
> 
> Tony
> 
> 8< -----------
> --- a/drivers/usb/musb/musb_virthub.c
> +++ b/drivers/usb/musb/musb_virthub.c
> @@ -291,6 +291,7 @@ int musb_hub_control(
>  	u32		temp;
>  	int		retval = 0;
>  	unsigned long	flags;
> +	bool		start_musb = false;
>  
>  	spin_lock_irqsave(&musb->lock, flags);
>  
> @@ -392,7 +393,7 @@ int musb_hub_control(
>  			 * logic relating to VBUS power-up.
>  			 */
>  			if (!hcd->self.is_b_host && musb_has_gadget(musb))
> -				musb_start(musb);
> +				start_musb = true;
>  			break;
>  		case USB_PORT_FEAT_RESET:
>  			musb_port_reset(musb, true);
> @@ -453,5 +454,9 @@ error:
>  		retval = -EPIPE;
>  	}
>  	spin_unlock_irqrestore(&musb->lock, flags);
> +
> +	if (start_musb)
> +		musb_start(musb);
> +
>  	return retval;
>  }

thank you,
	ladis
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux