* Ladislav Michl <ladis@xxxxxxxxxxxxxx> [160804 08:14]: > On Thu, Aug 04, 2016 at 07:01:21AM -0700, Tony Lindgren wrote: > > * Ladislav Michl <ladis@xxxxxxxxxxxxxx> [160803 10:07]: > > > With '[PATCH v2] musb: omap2430: do not assume balanced enable()/disable()' > > > it looks a bit "better": > > > > Do you need to do something specific to reproduce this? I'm not seeing > > this with omap2plus_defconfig with twl4030 phy at least. That's with > > musb as loadable modules. > > No, that's during boot, config is based on omap2plus_defconfig, but > everything is compiled in. Nothing is even connected into musb port. OK got it reproduced with the config you sent me, it seems to happen with USB_MUSB_HOST. Does the following work for you? Please check that devices enumerate too. Regards, Tony 8< ----------- --- a/drivers/usb/musb/musb_virthub.c +++ b/drivers/usb/musb/musb_virthub.c @@ -291,6 +291,7 @@ int musb_hub_control( u32 temp; int retval = 0; unsigned long flags; + bool start_musb = false; spin_lock_irqsave(&musb->lock, flags); @@ -392,7 +393,7 @@ int musb_hub_control( * logic relating to VBUS power-up. */ if (!hcd->self.is_b_host && musb_has_gadget(musb)) - musb_start(musb); + start_musb = true; break; case USB_PORT_FEAT_RESET: musb_port_reset(musb, true); @@ -453,5 +454,9 @@ error: retval = -EPIPE; } spin_unlock_irqrestore(&musb->lock, flags); + + if (start_musb) + musb_start(musb); + return retval; } -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
